Update Go #1673
Merged
Update Go #1673
+49
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SuperQ
commented
Apr 9, 2025
SuperQ
commented
- Update Go to 1.24.
- Update golangci-lint to v2.
- Fixup linting issues.
| run: | ||
| timeout: 5m | ||
|
|
||
| version: "2" |
There was a problem hiding this comment.
Nice, was this automatically converted? I see a couple oif linters are gone (e.g. gosimple and typecheck)
There was a problem hiding this comment.
Yes, this was automatically converted using golangci-lint migrate. The removed linters are gone from upstream anyway.
There was a problem hiding this comment.
From the migration guide:
https://golangci-lint.run/product/migration-guide/#lintersenableformatter_name
* Update Go to 1.24. * Update golangci-lint to v2. * Fixup linting issues. Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.