fixes #1881: Open generatorUrl in a new browser tab.

[dpryden]

There does not appear to be a good way to reliably determine in
onUrlRequest whether the URL being navigated to is an Internal or
External URL, especially if Alertmanager is hosted on the same domain as
other services (for example, Prometheus). To workaround this problem for
the specific case of the generatorUrlButton (labeled "Source"), we force
it to have target="_blank", which prevents Elm from intercepting the URL
and trying to do client-side navigation.

Signed-off-by: Daniel Pryden [email protected]

[dpryden]

This PR is supposed to be associated with #1881 but it doesn't seem to be linked, I'm not sure if I did something wrong when creating the PR.

[hooten]

The easiest way to link a PR to an issue is using a keyword in the PR description.

[dpryden]

The easiest way to link a PR to an issue is using a keyword in the PR description.

Thank you for your response, @hooten. Doesn't the commit message title contain a properly formatted keyword? That was my intention by writing fix #1881 at the start of the message.

[hooten]

@dpryden my bad! You're right. It looks like the commit message did in fact link the issue. Sorry for the confusion

[JohanElmis]

I'm having the same issue where I have a nginx frontend and proxies to alertmanager or different prometheus-hosts based on path.
The Alertmanager Source-link for an Alert just reloads the page as it is now, despite that the link is correct (works if copied and opened in new tab). This new-tab solution will work well for me.

[tommyk]

would love to see this issue get fixed. can we fix conflicts and merge? i can create another PR if this has been abandoned.

[dpryden]

Sorry, I haven't looked at this PR in ages, I actually forgot it was still open. I just rebased it and regenerated the asset/assets_vfsdata.go, I think it should be up to date now.

[dpryden]

@simonpasquier, you were the one who added the help wanted label on #1881 -- are you able to help review this?

[kerma]

Thanks for the fix @dpryden! @simonpasquier any way to get this reviewed/merged?