feat: dark mode #4394
Open
feat: dark mode #4394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth2353
force-pushed
the
bootstrap-dark-mode
branch
from
d866700 to
c7f9c3f
Compare
Open
eth2353
force-pushed
the
bootstrap-dark-mode
branch
from
c371966 to
3750a4c
Compare
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
Signed-off-by: eth2353 <[email protected]>
eth2353
force-pushed
the
bootstrap-dark-mode
branch
from
3750a4c to
48bfb55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review. I won't have time to work on this in the coming weeks so creating this draft PR. Perhaps someone can finish it up, otherwise I'll try to do so myself as soon as I can.
Adds a dark mode to the alertmanager UI:
The setting can be toggled in the Settings:
To do all this, I used the newly introduced dark color theme (introduced in Bootstrap 5.3). I refactored the DateTimePicker a bit (removing some custom CSS) since it required changes due to the Boostrap bump anyway.
We've been using this dark mode on one of our alertmanager instances for the last few months without issues.
The only issue I'm aware of at the moment relates to the responsiveness of the DateTimePicker - the hour/minute do not show on my phone (iPhone 12 mini) in portrait: