Skip to content

Use yaml.v3 to drop yaml.v2 direct dependency #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikelolasagasti wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use yaml.v3 to drop yaml.v2 direct dependency #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ require (
github.com/prometheus/exporter-toolkit v0.13.2
golang.org/x/net v0.33.0
google.golang.org/grpc v1.69.2
gopkg.in/yaml.v2 v2.4.0
gopkg.in/yaml.v3 v3.0.1
)

Expand All @@ -38,4 +37,5 @@ require (
golang.org/x/tools v0.22.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241015192408-796eee8c2d53 // indirect
google.golang.org/protobuf v1.35.2 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
)
2 changes: 1 addition & 1 deletion prober/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
"github.com/prometheus/client_golang/prometheus/promhttp"
"github.com/prometheus/common/expfmt"
"github.com/prometheus/common/promslog"
"gopkg.in/yaml.v2"
"gopkg.in/yaml.v3"
Copy link
Member

@electron0zero electron0zero Jan 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see @SuperQ's comment about blockers around upgrading to v3. go-yaml/yaml#665 (comment)

so I will hold and wait for @SuperQ's review on this before we merge this.

)

var (
Expand Down
Loading