Update dns.go #1469
Open
Update dns.go #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamala0309 <[email protected]>
SuperQ
requested changes
Oct 23, 2025
| Name: "probe_dns_query_succeeded", | ||
| Help: "Displays whether or not the query was executed successfully", | ||
| }) | ||
| // NEW METRIC |
Comment on lines
-266
to
-269
| // The rtt value returned from client.Exchange includes only the time to | ||
| // exchange messages with the server _after_ the connection is created. | ||
| // We compute the connection time as the total time for the operation | ||
| // minus the time for the actual request rtt. |
Member
There was a problem hiding this comment.
Why are you removing existing comments?
Comment on lines
+36
to
+38
| ) bool { | ||
| // reset metric at the start of each validation | ||
| probeFailedDueToRegex.Set(0) |
Member
There was a problem hiding this comment.
This would be a lot less fragile as a defer.
Something like:
Suggested change
| ) bool { | |
| // reset metric at the start of each validation | |
| probeFailedDueToRegex.Set(0) | |
| ) (valid bool) { | |
| defer func() { | |
| if valid { | |
| probeFailedDueToRegex.Set(0) | |
| } else { | |
| probeFailedDueToRegex.Set(1) | |
| } | |
| }() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring and registering the probeFailedDueToRegex gauge.
Passing it into validRRs and setting it to 1 whenever a regex validation fails.