metrics: add probe_ip_info gauge with labels {target, ip, protocol} #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o expose resolved IP and protocol during resolution
Member
|
The original change to add the IP address hash (as a value) was intentionally done that way to avoid the cardinality issues with exposing IP addresses. See the original PR: #584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds probe_ip_info=1 to expose the resolved IP and protocol (ip4 or ip6) during resolution including fallback paths. Rationale: improves observability for dual-stack behavior and IP changes. Changes: register and set probe_ip_info in chooseProtocol across all resolution branches. Backward compatibility: additive metric. Tests: assert presence and correct labels for IPv4 IPv6 and fallback.