Skip to content

Conversation

@electron0zero
Copy link
Member

@electron0zero electron0zero commented Jan 1, 2026

What this PR does / Which issue(s) does the PR fix:

Undo some of the log level changes made in #1461

Fixes #1509

Does this PR introduce a user-facing change?

NONE

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG added in release-notes section of PR Desc.

undo some of the log level changes made in
prometheus#1461

fixes prometheus#1509

Signed-off-by: Suraj Nath <[email protected]>
@SuperQ
Copy link
Member

SuperQ commented Jan 1, 2026

Shouldn't we make these Warn or maybe Debug?

👓 @tjhop

@electron0zero
Copy link
Member Author

electron0zero commented Jan 1, 2026

Shouldn't we make these Warn or maybe Debug?

not sure if Warn would address the log noise concerns folks are reporting, I am fine with both Debug or Info. @tjhop what do you say?

@datamuc
Copy link

datamuc commented Jan 5, 2026

Shouldn't we make these Warn or maybe Debug?

not sure if Warn would address the log noise concerns folks are reporting, I am fine with both Debug or Info. @tjhop what do you say?

I still think it should be debug.

@tjhop
Copy link
Contributor

tjhop commented Jan 5, 2026

For these error check cases where we're continuing on, I think going with debug logging makes sense in context here -- we would only really care about them if we needed to troubleshoot the entire flow of the probe. For the error checks where we actually stop and return, I think those should remain at error level, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to do unprivileged listen on socket,

4 participants