add tcp prober metric for tls_cipher_info - #1579
Open
nathwill wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nathan Williams <nath.e.will@gmail.com>
Author
|
i have no idea why circleci couldn't find the ref, it seems like perhaps github was backlogged when the PR was opened or something and circleci beat github to the punch, as it took several minutes to show up in the PR list UI, by which time the tests had already failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Which issue(s) does the PR fix:
adds tls_cipher_info metric to tcp prober
Does this PR introduce a user-facing change?
Checklist
release-notessection of PR Desc.