Log probe outcome failures at info instead of error - #1630
Open
locker95 wants to merge 1 commit into
Open
Conversation
Probe failures are operational results (target down, expected-fail modules, flaky networks), not blackbox_exporter errors. Logging them at error made them impossible to silence with --log.prober and mixed them with real exporter problems. Keep error level for configuration and local setup failures. Fixes prometheus#1510 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since v0.28.0, failed probes are logged at
error, which can't be filtered with--log.prober(highest filter is stillerror). That turns routine probe outcomes — timeouts, refused connections, expected-fail TCP modules, regex mismatches — into the same severity as real exporter problems.This demotes probe outcome failures to
info. Configuration / local setup failures stay aterror.Operators who want quiet probe logs can use
--log.prober=warnor--log.prober=error.Fixes #1510
How to verify