Support IDN targets via punycode conversion - #1633
Open
locker95 wants to merge 1 commit into
Open
Conversation
DNS lookups reject Unicode hostnames ("no such host"), so convert
names to ASCII with golang.org/x/net/idna before resolving and before
setting SNI / DNS query names. ASCII names and IP addresses are
unchanged.
Fixes prometheus#626
Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unicode hostnames such as
http://мтр24.рфfail DNS withno such host, while the punycode form works. Blackbox resolves hosts itself, so IDN never reaches Go's net/http IDNA handling.Convert hostnames to ASCII with
golang.org/x/net/idna(already a dependency viax/net) before:chooseProtocol— covers HTTP/TCP/ICMP/DNS/gRPC targets)query_nameand DoT SNIASCII names and IP addresses are left unchanged. Logs keep the original target label; only the resolved name is rewritten.
How to verify
Fixes #626