Count uncompressed body length from final HTTP response only - #1636
Open
locker95 wants to merge 1 commit into
Open
Count uncompressed body length from final HTTP response only#1636locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
Document and regression-test that the metric reflects only the final HTTP response body after redirects. Intermediate redirect payloads are discarded by net/http and must not affect the gauge. Clarify the metric HELP text accordingly. Fixes prometheus#896 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
probe_http_uncompressed_body_lengthshould reflect only the final response body after redirects. Intermediate 3xx payloads must not contribute.The prober already reads
resp.Bodyfrom the response returned byhttp.Client(the last hop). This change:Fixes #896
How to verify
go test ./prober/ -run TestUncompressedBodyLengthOnlyFinalResponse -count=1 -v