prober: support reject regexp in TCP/unix query_response - #1646
Open
locker95 wants to merge 1 commit into
Open
Conversation
Allow query_response steps to fail immediately when a line matches a reject pattern, instead of waiting for expect to time out. Fixes prometheus#1527 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For SMTP and friends you sometimes get a definitive failure line (
5xx) and just want the probe to stop, rather than spinning untilexpecttimes out.This adds an optional
rejectregex on eachquery_responsestep. While waiting forexpect, if a line matchesrejectthe probe fails right away (probe_failed_due_to_regex=1). Documented in CONFIGURATION.md; works for tcp and unix since they share the helper.Fixes #1527