Skip to content

chore: clean up golangci-lint configuration#1802

Merged
bwplotka merged 1 commit into
prometheus:mainfrom
mmorel-35:golangci-lint/clean-up
Sep 14, 2025
Merged

chore: clean up golangci-lint configuration#1802
bwplotka merged 1 commit into
prometheus:mainfrom
mmorel-35:golangci-lint/clean-up

Conversation

@mmorel-35

@mmorel-35 mmorel-35 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Description

chore: clean up golangci-lint configuration

@mmorel-35

mmorel-35 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

/cc @kakkoyun @SuperQ

@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch from e748448 to aa2ed7b Compare April 25, 2025 08:06

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment:

prometheus/procfs#720 (review)

Any concrete reasons for these changes?

@stale

stale Bot commented Jul 19, 2025

Copy link
Copy Markdown

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale label Jul 19, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch from aa2ed7b to 109111a Compare August 1, 2025 21:16
@stale stale Bot removed the stale label Aug 1, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch 6 times, most recently from d4375d1 to b4741a3 Compare August 1, 2025 21:19
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch from b4741a3 to 0142cdd Compare August 1, 2025 21:19
@mmorel-35 mmorel-35 requested a review from kakkoyun August 1, 2025 21:20
@mmorel-35 mmorel-35 changed the title chore: clean up and sort golangci-lint configuration chore: clean up golangci-lint configuration Aug 1, 2025

@bwplotka bwplotka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's more concise, but please next time provide a rationales in PRs description - otherwise we have to guess.

Thanks!

@bwplotka bwplotka merged commit a974e0d into prometheus:main Sep 14, 2025
8 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/clean-up branch September 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants