feat(http_config): support JWT token auth as alternative to client secret (RFC 7523 3.1) #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| default: | ||
| authorization := r.Header.Get("Authorization") | ||
| if authorization != "Bearer "+ExpectedAccessToken { |
There was a problem hiding this comment.
Consider adding a WriteHeader call with an appropriate HTTP status code in the default case when the 'Authorization' header does not match. This ensures that error responses are consistent and unambiguous.
Suggested change
| if authorization != "Bearer "+ExpectedAccessToken { | |
| if authorization != "Bearer "+ExpectedAccessToken { | |
| w.WriteHeader(http.StatusUnauthorized) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…cret (RFC 7523 3.1) Signed-off-by: Jan-Otto Kröpke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements JWT Authentication for Authorization Grant (RFC 7523 3.1) as alternative to static client credentials.
As I know, this auth flow is used by STACKIT Service Accounts (Key Flow).
I tried to not break any exists method signatures to remain backwards compatibility.
Note: This PR does not provide support for JWTs in Client Authentication Processing, since it not supported by x/oauth2 yet. See golang/oauth2#745
As I know, JWTs in Client Authentication Processing is used by Microsoft Entra ID (Client Certificates).