config: add OAuth2 token_url_file#944
Open
dtrejod wants to merge 1 commit into
Open
Conversation
Signed-off-by: Devin Trejo <dtrejo@palantir.com>
dtrejod
force-pushed
the
dt/addtokenurlfile
branch
from
84afbe2 to
9052284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
token_url_filefield to the OAuth2 HTTP client config, alongside the existingtoken_urlconfig. The token URL is read from the file when the OAuth2 token source is (re)built, so deploy-time-injected values (e.g. Helm-managed files, mounted Secrets/ConfigMaps) work without needing the URL to be known at config-authoring time.Exactly one of
token_urlortoken_url_filemust be set. Configs that set both, or neither, fail validation.See prometheus/alertmanager#4759