refactor(om2): rename, align Created Value to Created Timestamp #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's a bit confusing when we want to refer to the value of a Created Value, for example when we list values like Sum, Count, Created Value values. Also why isn't the token for the Created Value cv@ ? Create Timestamp seems cleaner to me. Signed-off-by: György Krajcsovits <[email protected]>
ArthurSens
approved these changes
Jul 1, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Yeah, that's a lot better. LGTM
jesusvazquez
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a bit confusing when we want to refer to the value of a Created Value, for example when we list values like Sum, Count, Created Value values.
Also why isn't the token for the Created Value cv@ ? Create Timestamp seems cleaner to me.
For your consideration :)