OM 2.0: Remove MetricPoint concept, and use Sample#2894
Open
dashpole wants to merge 6 commits intoprometheus:mainfrom
Open
OM 2.0: Remove MetricPoint concept, and use Sample#2894dashpole wants to merge 6 commits intoprometheus:mainfrom
dashpole wants to merge 6 commits intoprometheus:mainfrom
Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
metricpoint_to_sample
branch
from
2c9d9ae to
65176e7
Compare
Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
metricpoint_to_sample
branch
from
65176e7 to
4c240ac
Compare
bwplotka
reviewed
Mar 13, 2026
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
metricpoint_to_sample
branch
from
c1aed15 to
aad8d1d
Compare
Signed-off-by: David Ashpole <dashpole@google.com>
Contributor
Author
|
I addressed all the open comments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/OpenMetrics#315
This aligns with the structure in slide 2 of prometheus/OpenMetrics#315 (comment)