Fixed code to use the Java system properties for keystore and truststo…#1126
Merged
dhoard merged 2 commits intoprometheus:mainfrom Feb 7, 2025
Merged
Conversation
Collaborator
Author
|
@gtully I found some inconsistency in the keystore/truststore type handling in the existing The code didn't use the Java system property (if defined). I made some changes to be more consistent. Can you take a look? Thanks! |
dhoard
changed the title
…ore types if not configured in exporter.yaml Signed-off-by: dhoard <doug.hoard@gmail.com>
dhoard
force-pushed
the
fix-keystore-truststore-default-types
branch
from
daff41a to
86ec112
Compare
gtully
reviewed
Feb 10, 2025
Contributor
gtully
left a comment
gtully
left a comment
There was a problem hiding this comment.
that looks sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re types if not configured in exporter.yaml