Skip to content

issue #746: return 429 Too Many Requests if requests stack up #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mysqld_exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,16 @@ func init() {
}

func newHandler(scrapers []collector.Scraper, logger log.Logger) http.HandlerFunc {
processing := false
return func(w http.ResponseWriter, r *http.Request) {
if processing {
log.Info("Received metrics request while previous still in progress: returning 429 Too Many Requests")
http.Error(w, "429 Too Many Requests", http.StatusTooManyRequests)
return
}
processing = true
defer func() { processing = false }()

var dsn string
var err error
target := ""
Expand Down