Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mixin dashboard to editable: false #911

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

grooverdan
Copy link
Contributor

This was reported by the mixtool lint:
mixtool lint mixin.libsonnet
[uneditable-dashboard] 'MySQL': Dashboard 'MySQL' is editable, it should be set to 'editable: false'

This is quick attempt at fixing the mixin CI error going by its error description. I haven't looked further on the implications of this.

This was reported by the mixtool lint:
  mixtool lint mixin.libsonnet
  [uneditable-dashboard] 'MySQL': Dashboard 'MySQL' is editable, it should be set to 'editable: false'

Signed-off-by: Daniel Black <[email protected]>
Copy link
Contributor

@rgeyer rgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is mostly a cosmetic/continuity rule. The result is that when it is imported into Grafana, the dashboard will be read-only by default.

It can, of course, be overwritten by a user with adequate permissions.

@SuperQ SuperQ merged commit 27ef617 into prometheus:main Feb 14, 2025
13 checks passed
@grooverdan grooverdan deleted the mixin branch February 14, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants