Fix #905: use SUM_LOCK_TIME and SUM_CPU_TIME with mysql >= 8.0.28 #916
+238
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiangreco
force-pushed
the
cristian/issue-905
branch
from
a6f8246 to
12ad6a1
Compare
…8.0.28 Fix issue introduced in prometheus#862 Only query SUM_LOCK_TIME and SUM_CPU_TIME when using MySQL >= 8.0.28. Fixes prometheus#905 Signed-off-by: Cristian Greco <[email protected]>
cristiangreco
force-pushed
the
cristian/issue-905
branch
from
12ad6a1 to
22c7a26
Compare
matthewnolf
reviewed
Feb 11, 2025
matthewnolf
approved these changes
Feb 11, 2025
|
I think we typically version the whole query rather than try and do string manipulation. |
cristiangreco
force-pushed
the
cristian/issue-905
branch
from
eb1e4d3 to
f2955ea
Compare
Signed-off-by: Cristian Greco <[email protected]>
cristiangreco
force-pushed
the
cristian/issue-905
branch
from
f2955ea to
28bb162
Compare
cristiangreco
commented
Feb 14, 2025
Comment on lines
+44
to
+46
| if pb.Summary != nil { | ||
| return MetricResult{labels: labels, value: pb.GetSummary().GetSampleSum(), metricType: dto.MetricType_SUMMARY} | ||
| } |
There was a problem hiding this comment.
Ideally would add quantiles as well, but that seems too much refactoring for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue introduced in #862
Only query SUM_LOCK_TIME and SUM_CPU_TIME when using MySQL >= 8.0.28.
Fixes #905