Add step(), min() and max() in promql duration expressions#16777
Merged
roidelapluie merged 4 commits intoprometheus:mainfrom Jul 2, 2025
Merged
Add step(), min() and max() in promql duration expressions#16777roidelapluie merged 4 commits intoprometheus:mainfrom
roidelapluie merged 4 commits intoprometheus:mainfrom
Conversation
roidelapluie
force-pushed
the
add-step-promql
branch
5 times, most recently
from
6253826 to
ff7572c
Compare
roidelapluie
changed the title
roidelapluie
force-pushed
the
add-step-promql
branch
3 times, most recently
from
b549206 to
140abe4
Compare
roidelapluie
force-pushed
the
add-step-promql
branch
from
140abe4 to
6b35e78
Compare
roidelapluie
force-pushed
the
add-step-promql
branch
from
f0d7b27 to
73b2a12
Compare
Member
Author
I have updated the PR with your comments. |
Member
Author
|
Funnily enough, rate [5m x 5m] was parsed correctly. Fixed by this PR too. |
roidelapluie
force-pushed
the
add-step-promql
branch
3 times, most recently
from
0eeced5 to
532e386
Compare
roidelapluie
force-pushed
the
add-step-promql
branch
from
a065ef3 to
62d830c
Compare
darshanime
reviewed
Jun 29, 2025
krajorama
reviewed
Jun 30, 2025
Member
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
Looks good, but I wonder if adding min/max was intentional?
If yes, please update PR description as well.
roidelapluie
force-pushed
the
add-step-promql
branch
4 times, most recently
from
c4bdbb7 to
02cca53
Compare
roidelapluie
changed the title
krajorama
reviewed
Jul 1, 2025
Member
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
LGTM, just a couple of more unit test cases 2x2 and you're done I think
roidelapluie
force-pushed
the
add-step-promql
branch
from
02cca53 to
767870d
Compare
krajorama
approved these changes
Jul 1, 2025
Member
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
LGTM. I'm OK with this, especially since this is experimental and I'm not likely to spot random edge cases.
beorn7
requested changes
Jul 1, 2025
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Just nit-picking left for documentation. Otherwise LGTM.
step() is a new keyword introduced to represent the query step width in duration expressions. min(a,b) and max(a,b) return the min and max from two duration expressions. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Signed-off-by: Julien <291750+roidelapluie@users.noreply.github.com>
roidelapluie
force-pushed
the
add-step-promql
branch
from
0e14c9b to
432f130
Compare
beorn7
approved these changes
Jul 2, 2025
This was referenced Jul 31, 2025
Contributor
|
Adding a quick summary of what's added here as best I can tell:
|
Member
|
Yes, it returns the step parameter from the range query. This is deliberate. (You know the step for a sub query anyway as it is set in the very same query.) |
Member
|
Ref #15862 (comment) where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.