proposal: Support secret providers#47
Conversation
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
|
LGTM. can you just update the description of the pull request for posteriority. |
bwplotka
left a comment
There was a problem hiding this comment.
LGTM generally! Just last nit noted by @rajagopalanand and good to go IMO!
Approving from my side, but I will ask around for a second Prometheus maintainer to have another look
ArthurSens
left a comment
There was a problem hiding this comment.
Looks pretty solid :) I just had some small questions
bwplotka
left a comment
There was a problem hiding this comment.
Amazing feedback and discussion in https://github.com/prometheus/proposals/pull/47/files#r2041335383
Should we update the proposal with the mentioned alternatives considered?
What do you think is the reasonable solution from this discussion? I see the potential for changing proposal slightly to support the following (for consistency with SD):
password: "<inlined secret>"password:
kubernetes:
namespace: "<ns>"
name: "<secret name>"
key: "<data's key for secret name>"password:
file:
path: "<path to secret file>"|
I vote for changing the proposal to be consistent with SD |
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
535a36e to
9891e9c
Compare
d726925 to
b918d59
Compare
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
b918d59 to
ec70387
Compare
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
saswatamcode
left a comment
There was a problem hiding this comment.
Thanks! Excited to see this in action. :)
|
I changed the config style to be more consistent with SD in the proposal. Thanks everyone for all the feedback, and feel free to reach out on the prometheus slack if you have any feedback or ideas. I am working on an implementation for the proposal:) |
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! @dgl @machine424 -- are you ok to merge? 🤗
ArthurSens
left a comment
There was a problem hiding this comment.
LGTM, one last question :)
Signed-off-by: Henrique Spanoudis Matulis <hmatulis@google.com>
ArthurSens
left a comment
There was a problem hiding this comment.
Thanks for workin on the proposal, I'm merging as soon as you tell me you're satisfied :)
|
I think I am ready to merge it, thanks everyone! |
proposal: Support secret providers
This PR adds a proposal to support specifying secrets through secret providers.
TL;DR from doc