-
Notifications
You must be signed in to change notification settings - Fork 25
proposal: PROM-<number> Proposal Referencing #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| ## Proposal IDs | ||
|
|
||
| * **Owners:** | ||
| * `@bwplotka` | ||
|
|
||
| * **Implementation Status:** `Implemented` | ||
|
|
||
| * **Related Issues and PRs:** | ||
| * https://github.com/prometheus/proposals/issues/51 | ||
|
|
||
| > TL;DR: We propose every Prometheus proposal has a stable reference/ID in the form of the PROM-<number>. The number is the PR ID from the original PR that was used to discuss and approve the proposal. | ||
|
|
||
| ## Why | ||
|
|
||
| It's important to reference decisions made in the proposal in the following development (code, docs, discussions). Currently, we either have some tribal naming for a proposal, link to a proposal repo PR when proposal is not yet approved or GH link to the proposal file with that original `<date>-template.md`. | ||
|
|
||
| We want to ensure that "link" is even more consistent, stable and short than the current approach. | ||
|
|
||
| ### Pitfalls of the current solution | ||
|
|
||
| * We use inconsistent references (name, PR link, file link). | ||
| * The references e.g. links are hard to use (e.g. mentioning in the code commentary) and hard to memorize. | ||
| * The date in the file is usually misleading. It's a creation date vs approval date (the latter might be what we usually expect). | ||
| * While we try to ensure links in the `proposal/` directory never change, there's a risk we break those one day. | ||
|
|
||
| ## Goals | ||
|
|
||
| Goals and use cases for the solution as proposed in [How](#how): | ||
|
|
||
| * Each proposal has a short, memorable and unique ID. | ||
|
|
||
| ## How | ||
|
|
||
| We propose every Prometheus proposal has a stable reference/ID in the form of the `PROM-<number>`. This number is captured in the file name and it origins from the ID of the Pull Request that was used to approve and merge the proposal. | ||
bwplotka marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| We propose to NOT add stable number of digits in the official referencing. However, we propose we DO add stable number of digits in the file name, so the file browsing has a convenient ordering. We propose 4 digits for now, prefixed by zeros, which can be increased to 5 once we have PR numbers in ten-thousands (likely in a decade). | ||
bwplotka marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| For example, this proposal is referenced as `PROM-53`, because we proposed this in the [PR `#53`](https://github.com/prometheus/proposals/pulls/53). This proposal file name is then `0053-proposal-ids.md`. | ||
|
|
||
| For the existing proposals, we propose to rename existing proposal's file to have its PROM-<number> (based on their initial PRs), but leave the old files with a link to a new file, so the old links work. | ||
|
|
||
| ## Alternatives | ||
|
|
||
| ### Different Prefixes | ||
|
|
||
| There are a few alternatives to the `PROM-` prefix e.g. | ||
|
|
||
| * PEP- ("Prometheus Enhancement Proposal") | ||
| * Consistent with K8s and Otel, but Prometheus community never used "EP" naming. | ||
bwplotka marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * P- or PP- ("Prometheus Proposal") | ||
| * Short but NOT clearly unique for Prometheus and not suggesting proposals | ||
| * PROMETHEUS- | ||
| * A bit too long? | ||
|
|
||
| ## Action Plan | ||
|
|
||
| The tasks to do in order to migrate to the new idea. | ||
|
|
||
| * [X] Adjust template and proposal docs. | ||
| * [ ] Rename existing proposal's file to have its PROM-<number>; Leave the old files with a link to a new file, so the old links work. | ||
bwplotka marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.