chore(generator): fail early for bad walk OID #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/walk
branch
2 times, most recently
from
27c6aa7 to
dda4c35
Compare
SuperQ
reviewed
Apr 16, 2025
JohnVillalovos
force-pushed
the
jlvillal/walk
branch
from
dda4c35 to
f768ecc
Compare
JohnVillalovos
changed the title
|
Example run: |
|
This needs a DCO sign-off. You can use |
JohnVillalovos
force-pushed
the
jlvillal/walk
branch
from
f768ecc to
8b3332f
Compare
Done. |
|
@SuperQ There is a failing test but it seems unrelated to my change. As it is a failure in downloading a MIB. Please let me know if there are any other changes you would like. Thanks. |
|
See #1412 |
|
checks now fixed - go ahead 🚶 |
In `generator.yml` and in a `walk:` section. If an OID starts with a period, for example `.1.3.6.1.4.1.20916`, this will fail to be found, as it should be: `1.3.6.1.4.1.20916`. But the error message lacks detail when this happens. Fail early if an OID starts with a "." and explain why. Signed-off-by: John L. Villalovos <[email protected]>
JohnVillalovos
force-pushed
the
jlvillal/walk
branch
from
163a25d to
6fa705d
Compare
Thanks. I went ahead and rebased it. |
SuperQ
approved these changes
Apr 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
generator.ymland in awalk:section. If an OID starts with aperiod, for example
.1.3.6.1.4.1.20916, this will fail to be found,as it should be:
1.3.6.1.4.1.20916. But the error message lacksdetail when this happens.
Fail early if an OID starts with a "." and explain why.