Skip to content

bring mikrotik mib up to date (7.18.2) (wifi(wave2/-qcom) focussed) #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

hirnpfirsich
Copy link

@hirnpfirsich hirnpfirsich commented Apr 19, 2025

Hello everyone ! :)

this pr bumps the mikrotik mib file to the current stable version of routeros (which is 7.18.2) source.
The download url now directly annotates which version of the mib file will be downloaded (which is nice).

My focus for this work was to be able to gather capsman information from my devices (which is the wifi controller in the routeros world - we had support for legacy wifi capsman (<= wifi 5) but not new world capsman (>= wifi 6)). Therefore I also added a few overrides and lookups for this specific data.

Because the mib file for mikrotik hasn't been updated in 5 years there are a lot more things one could beautify via lookups etc..
Additionally maybe this update introduced breaking changes for some people.
I did not check the mib files so detailed for changes because I thought that this has to happen eventually.
(see next comment)

Excited to hear your feedback :)

Greetings from Leipzig (germany) !

@hirnpfirsich
Copy link
Author

hirnpfirsich commented Apr 19, 2025

Holy shit your CI/CD is comparing changes between a known good snmp.yml and this pr - this so so smart !

Then I am going to mark this comment as obsolete:

Additionally maybe this update introduced breaking changes for some people.
I did not check the mib files so detailed for changes because I thought that this has to happen eventually.

My change did not remove any metrics / keys - it only added new ones.
source

@bastischubert
Copy link
Member

Hey @hirnpfirsich , please add the changes from snmp.yml to this PR as well so we can merge it.

@hirnpfirsich
Copy link
Author

@bastischubert done :)

Copy link
Member

@bastischubert bastischubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bastischubert bastischubert merged commit 59c51b3 into prometheus:main Apr 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants