Skip to content

included rules in PromBench as a configmap #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kushalShukla-web wants to merge 2 commits into
base: master
Choose a base branch
from
Open

included rules in PromBench as a configmap #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3eab4
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
kushalShukla-web Feb 22, 2025
75c234c
Merge branch 'master' into recordingrules
kushalShukla-web Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...prombench/benchmark/2_fake-webserver.yaml → ...rombench/benchmark/2a_fake-webserver.yaml
View file
Open in desktop
File renamed without changes.
25 changes: 25 additions & 0 deletions prombench/manifests/prombench/benchmark/2b_prometheus-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: prometheus-rules
namespace: prombench-{{ .PR_NUMBER }}
data:
rules.yml: |
groups:
- name: recording_rules
interval: 15s
rules:
- record: instance:codelab_api_requests:rate5m
expr: sum by(instance) (rate(codelab_api_requests_total{method=~"GET|POST"}[5m]))

- record: instance:node_cpu_usage:rate5m
expr: sum by(instance) (rate(node_cpu_seconds_total{mode!="idle"}[5m]))

- record: instance:codelab_api_request_duration:quantile_99
expr: histogram_quantile(0.99, sum by(instance, le) (rate(codelab_api_request_duration_seconds_bucket{method="POST"}[5m])))

- record: instance:codelab_api_request_duration_seconds_count:filtered
expr: codelab_api_request_duration_seconds_count{method="POST"} unless codelab_api_request_duration_seconds_count{status="500"}

- record: instance:codelab_api_request_duration_seconds_count:top10
expr: topk(10, sum(codelab_api_request_duration_seconds_count) by (method, job))
9 changes: 9 additions & 0 deletions prombench/manifests/prombench/benchmark/3_prometheus-test-pr_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ data:
prometheus.yml: |
global:
scrape_interval: 15s
evaluation_interval: 15s

rule_files:
- "/etc/prometheus/rules/rules.yml"

scrape_configs:
- job_name: kubelets
Expand Down Expand Up @@ -805,6 +809,8 @@ spec:
mountPath: /prometheus
- name: prometheus-executable
mountPath: /usr/bin
- name: prometheus-rules
mountPath: /etc/prometheus/rules
ports:
- name: prom-web
containerPort: 9090
Expand All @@ -818,6 +824,9 @@ spec:
path: /mnt/disks/ssd0
- name: prometheus-executable
emptyDir: {}
- name: prometheus-rules
configMap:
name: prometheus-rules
terminationGracePeriodSeconds: 300
nodeSelector:
node-name: prometheus-{{ .PR_NUMBER }}
Expand Down
9 changes: 9 additions & 0 deletions prombench/manifests/prombench/benchmark/3_prometheus-test-release_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ data:
prometheus.yml: |
global:
scrape_interval: 15s
evaluation_interval: 15s

rule_files:
- "/etc/prometheus/rules/rules.yml"

scrape_configs:
- job_name: kubelets
Expand Down Expand Up @@ -777,6 +781,8 @@ spec:
mountPath: /etc/prometheus
- name: instance-ssd
mountPath: /prometheus
- name: prometheus-rules
mountPath: /etc/prometheus/rules
ports:
- name: prom-web
containerPort: 9090
Expand All @@ -788,6 +794,9 @@ spec:
hostPath:
# /mnt is where GKE keeps it's SSD.
path: /mnt/disks/ssd0
- name: prometheus-rules
configMap:
name: prometheus-rules
terminationGracePeriodSeconds: 300
nodeSelector:
node-name: prometheus-{{ .PR_NUMBER }}
Expand Down
4 changes: 0 additions & 4 deletions prombench/manifests/prombench/benchmark/6_loadgen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ data:
- expr: sum by(instance) (rate(node_cpu_seconds_total{mode!="idle"}[5m]))
- expr: sum by(instance) (rate(node_cpu_seconds_total[5m]))
- expr: sum by(instance) (rate(codelab_api_requests_total[5m]))
- expr: sum by(instance) (rate(codelab_api_requests_total{method=~"GET|POST"}[5m]))
- name: aggr_range
interval: 30s
type: range
Expand All @@ -36,7 +35,6 @@ data:
step: 15s
queries:
- expr: sum by(image) (container_memory_rss)
- expr: sum by(instance) (rate(node_cpu_seconds_total{mode!="idle"}[5m]))
- expr: sum by(instance) (rate(node_cpu_seconds_total[5m]))
- expr: sum by(instance) (rate(codelab_api_requests_total[5m]))
- expr: sum by(instance) (rate(codelab_api_requests_total{method=~"GET|POST"}[5m]))
Expand All @@ -60,13 +58,11 @@ data:
type: instant
queries:
- expr: codelab_api_request_duration_seconds_sum{status="200"} or codelab_api_request_duration_seconds_sum{status="500"}
- expr: codelab_api_request_duration_seconds_count{method="POST"} unless codelab_api_request_duration_seconds_count{status="500"}
- name: topk
interval: 10s
type: instant
queries:
- expr: topk(20, sum(rate(go_gc_duration_seconds_count[5m])) by (instance, job))
- expr: topk(10, sum(codelab_api_request_duration_seconds_count) by (method,job))
---
apiVersion: apps/v1
kind: Deployment
Expand Down