-
Notifications
You must be signed in to change notification settings - Fork 30
Generalized Superstructure for recovering rare earth elements from an end-of-life product. #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChrisLaliwala
wants to merge
27
commits into
prommis:main
Choose a base branch
from
ChrisLaliwala:PR-Superstructure_V2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase studies. Superstructures currently exist as python notebooks and the frameworks for the superstructures consider economic and environmental objectives. Superstructures need to be expanded to include more processes for byproduct and iron recovery though.
…e working correctly.
…eralized superstructure function to make comments more clear.
…re skipped if solver is not available.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 97.03% 89.76% -7.28%
==========================================
Files 65 68 +3
Lines 9715 11215 +1500
==========================================
+ Hits 9427 10067 +640
- Misses 288 1148 +860 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tests and then format code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue:
Summary/Motivation:
The PR introduces a generalized superstructure function that can be used to find the optimal processing pathway for recovering critical minerals from different end-of-life (EOL) products based on user-specified inputs. The user has the option to maximize the net present value (NPV), or minimize the cost of recovery (COR). Additionally, the user can also consider the valorization of byproducts, and the ability to perform multi-objective optimization considering the LCA emission metric of Global Warming Potential.
Changes proposed in this PR:
Reviewer's checklist / merge requirements:
main
branch on the PR author's forkLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
I agree my contributions are submitted under the license terms described in the LICENSE.md file
at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has
rights to intellectual property that includes these contributions, I represent that I have
received permission to make contributions and grant the required license on behalf of that
employer.