Skip to content

Generalized Superstructure for recovering rare earth elements from an end-of-life product. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

ChrisLaliwala
Copy link
Contributor

@ChrisLaliwala ChrisLaliwala commented Mar 18, 2025

Addresses Issue:

Summary/Motivation:

The PR introduces a generalized superstructure function that can be used to find the optimal processing pathway for recovering critical minerals from different end-of-life (EOL) products based on user-specified inputs. The user has the option to maximize the net present value (NPV), or minimize the cost of recovery (COR). Additionally, the user can also consider the valorization of byproducts, and the ability to perform multi-objective optimization considering the LCA emission metric of Global Warming Potential.

Changes proposed in this PR:

  • Generalized superstructure function

Reviewer's checklist / merge requirements:

  • The head branch (i.e. the "source" of the changes) is not the main branch on the PR author's fork
  • Documentation
  • Tests
  • Diagnostic tests for models

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md file
    at the top level of this directory.

  2. I represent I am authorized to make the contributions and grant the license. If my employer has
    rights to intellectual property that includes these contributions, I represent that I have
    received permission to make contributions and grant the required license on behalf of that
    employer.

…ase studies. Superstructures currently exist as python notebooks and the frameworks for the superstructures consider economic and environmental objectives. Superstructures need to be expanded to include more processes for byproduct and iron recovery though.
@ChrisLaliwala ChrisLaliwala changed the title Generalized Superstructure for recovering rare earth elements from an end-of-life product. Generalized Superstructure (version 2) for recovering rare earth elements from an end-of-life product. Mar 18, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 99.30070% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (5a1c38c) to head (a3c517d).

Files with missing lines Patch % Lines
...mmis/superstructures/version2/superstructure_v2.py 99.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   97.03%   89.76%   -7.28%     
==========================================
  Files          65       68       +3     
  Lines        9715    11215    +1500     
==========================================
+ Hits         9427    10067     +640     
- Misses        288     1148     +860     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Mar 31, 2025
@ChrisLaliwala ChrisLaliwala marked this pull request as ready for review April 29, 2025 03:14
@ChrisLaliwala ChrisLaliwala changed the title Generalized Superstructure (version 2) for recovering rare earth elements from an end-of-life product. Generalized Superstructure for recovering rare earth elements from an end-of-life product. May 7, 2025
@ChrisLaliwala ChrisLaliwala requested a review from OOAmusat May 7, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants