Precipitation calculation with isotherms #99
Conversation
agarciadiego
added
Priority:High
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 96.98% 96.99%
=======================================
Files 48 48
Lines 7540 7557 +17
=======================================
+ Hits 7313 7330 +17
Misses 227 227 ☔ View full report in Codecov by Sentry. |
| ) | ||
|
|
||
| self.acid_flow = Var( | ||
| units=units.dimensionless, |
There was a problem hiding this comment.
This looks like it really should have dimensions.
Also, how reliably can be define the upper bound for this (which probably depends on the units)?
|
|
||
| # parameter based on pH 1.5 | ||
| # TODO add surrogate model/equation | ||
| self.E_D = Param( |
There was a problem hiding this comment.
A more descriptive name and/or a doc string would be good here as I do not really know what I am looking at at the moment.
|
|
||
| # parameter based on pH 1.5 | ||
| # TODO add surrogate model/equation | ||
| self.N_D = Param( |
|
Seems like this PR still needs to address Andrew's comments as well as resolving some of the |
|
@agarciadiego, any news on this? |
|
|
||
| # parameter based on pH 1.5 | ||
| # TODO add surrogate model/equation | ||
| self.E_D = Param( |
|
|
||
| # parameter based on pH 1.5 | ||
| # TODO add surrogate model/equation | ||
| self.N_D = Param( |
| Reaction package for heterogeneous reactions involved in oxalate precipiration of | ||
| REEs from solid West Kentucky No. 13 coal refuse using oxalic acid. |
There was a problem hiding this comment.
| Reaction package for heterogeneous reactions involved in oxalate precipiration of | |
| REEs from solid West Kentucky No. 13 coal refuse using oxalic acid. | |
| Reaction package for heterogeneous reactions involved in oxalate precipitation of | |
| REEs from solid West Kentucky No. 13 coal refuse using oxalic acid. |
| } | ||
|
|
||
| # parameter based on pH 1.5 | ||
| self.E_D = Param( |
There was a problem hiding this comment.
Better name or docstring
| ) | ||
|
|
||
| # parameter based on pH 1.5 | ||
| self.N_D = Param( |
There was a problem hiding this comment.
Better name or docstring
|
|
||
| def build(self): | ||
| """ | ||
| Reaction block for leaching of West Kentucky No. 13 coal refuse in H2SO4. |
There was a problem hiding this comment.
Is this docstring accurate?
|
|
||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # Leach solution property package |
There was a problem hiding this comment.
Precipitation liquid property package?
| # Precipitator unit model | ||
| class OxalatePrecipitatorInitializer(ModularInitializerBase): | ||
| """ | ||
| This is a general purpose Initializer for the Oxalate Precipitator unit model. |
There was a problem hiding this comment.
| This is a general purpose Initializer for the Oxalate Precipitator unit model. | |
| This is a general purpose Initializer for the Oxalate Precipitator unit model. |
src/prommis/uky/uky_flowsheet.py
Outdated
| initializer_precip = OxalatePrecipitatorInitializer() | ||
| precip_units = [ | ||
| m.fs.precipitator, | ||
| ] | ||
|
|
There was a problem hiding this comment.
Running into the following issue with OxalatePrecipitatorInitializer: idaes.core.util.exceptions.InitializationError: Degrees of freedom for fs.precipitator.mscontactor were not equal to zero during initialization (DoF = 13). The SXInitializer had a similar issue when it was first being developed - see Andrew's comment here on a potential fix: #85 (comment)
|
per @MarcusHolly I (@dangunter ) will check how to add new outputs from L1572-2121 in |
|
@MarcusHolly I added a version of the Once the new version is verified, of course you can replace |
Addresses Issue:
Lack of prediction from previous precipitation data
Summary/Motivation:
Precipitation requires function to calculate precipitation based on acid dosage
Changes proposed in this PR:
-Adds isotherm form calculation for oxalate precipitation based on acid dosage
-Data based on Visual Minteq
Reviewer's checklist / merge requirements:
mainbranch on the PR author's forkLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
I agree my contributions are submitted under the license terms described in the LICENSE.md file
at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has
rights to intellectual property that includes these contributions, I represent that I have
received permission to make contributions and grant the required license on behalf of that
employer.