-
Notifications
You must be signed in to change notification settings - Fork 26
feat: expose rpc retry configuration #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kayibal
wants to merge
150
commits into
main
Choose a base branch
from
ah/ENG-5026/expose-rpc-retry-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_metadata.rs Co-authored-by: Zizou <[email protected]>
This will instead be tracked inside DCI. It doesn't need to be part of the metadata interfaces if it's not used.
This commit polishes the implementation for the component -> metadata generator and routing key -> request provider registries. Also add some unit tests for them.
- Introduced `RPCMetadataProvider` to handle batch execution of RPC requests. - Updated `RequestProvider` trait to return results with deduplication IDs. - Added grouping logic for requests based on a specified batch size. - Included tests for the new provider and its functionality. - Updated dependencies to include `mockito` for testing purposes.
This will be used to customize how we deal with the response from RPC/APIs and parse them differently depending on the protocol.
This was removed in a earlier commit in this PR but it's actually needed by tycho-simulation. This commits adds it back with an implementation for Euler.
…t_generator.rs Co-authored-by: Zizou <[email protected]>
This allows to add a warning message if Code is None and change_type is Creation.
Since we are having issues with these fields, they are made private to scope down the potential modules that might be causing the issues. Also added warnings that should help catch the specific location of this happening.
Added a debug mode to log raw JSON responses for easier troubleshooting of deserialization errors.
This will make debugging DCI cache easier.
This avoids crashing if one rpc requests fails or gets rate limited. Once we correctly return a retry-after header from the server, the client will respect it and requests will wait until then.
Some protocols need to retrieve a lot of data. This allows us to wait for their startup properly.
123f8d1 to
3114dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.