feat(client): handle filtering paused components #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayibal
reviewed
Sep 24, 2025
Comment on lines
+368
to
+378
| // If the component is unpaused, we need to add it | ||
| if s.deleted_attributes.contains("paused") { | ||
| to_add.push(id.clone()); | ||
| } | ||
| // If the component is paused, we need to remove it | ||
| else if s | ||
| .updated_attributes | ||
| .contains_key("paused") | ||
| { | ||
| to_remove.push(id.clone()); | ||
| } |
Contributor
There was a problem hiding this comment.
I would prefer if we used the actual value of the attribute. So if not present or =0 -> unpaused if present and > 0 then paused.
Collaborator
Author
There was a problem hiding this comment.
According to the plans, on the indexer/sdk side we are deleting the attribute to unpause it, we're never setting this to 0. See here
Do we still want this, just in case?
|
|
||
| impl ResponseProtocolState { | ||
| pub fn is_paused(&self) -> bool { | ||
| self.attributes.contains_key("paused") |
Contributor
There was a problem hiding this comment.
Again would prefer to rely on the attribute value here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.