fluid-substreams #174
Open
fluid-substreams #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayibal
reviewed
Mar 11, 2025
| component_changes: vec![ProtocolComponent { | ||
| id: event.dex.to_hex(), | ||
| tokens: vec![], | ||
| contracts: vec![], |
Contributor
There was a problem hiding this comment.
Need to set contracts addresses here that are required to simulate a swap.
Author
There was a problem hiding this comment.
will update this once i confirm the address
There was a problem hiding this comment.
so the dex address?
or also our DexReservesResolver where we call the estimateSwapIn method? (see getPriceAt)
or the full set of contracts that can be involved, so also our liquidity layer and extensions of it?
| name: "fluid_dex_pool".to_string(), | ||
| financial_type: FinancialType::Swap.into(), | ||
| attribute_schema: vec![], | ||
| implementation_type: ImplementationType::Custom.into(), |
Contributor
There was a problem hiding this comment.
This should be `ImplementationType::VM'
| |addr| { | ||
| // we assume that the store holds contract addresses as keys and if it | ||
| // contains a value, that contract is of relevance. | ||
| // TODO: if you have any additional static contracts that need to be indexed, |
Contributor
There was a problem hiding this comment.
I think we do have some static contracts that we need to include here like the liquidity layer?
bergben
reviewed
Mar 11, 2025
evm/src/fluid/FluidAdapter.sol
Outdated
| return trade; | ||
| } | ||
|
|
||
| event logInner(string, uint256); |
Can't use impl_ as variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.