feat: Validator trait + implementation for USV2 #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this trait to help us find out when our delta transitioning causes our local state to diverge from on-chain. - I had to downcast in the end, since we didn't want to add the Validator trait to the ProtocolSim trait requirement (we would need to change tycho_common). We can't just change the integration test to require the Validator trait, since this would require this change in a few other places (such as the Update struct), and it's slightly unintuitive that it would return Validator here instead of ProtocolSim. The simplest, albeit slightly hacky solution is to try to downcast before validating, and return None if we aren't able to downcast to that specific pool state.
tamaralipows
commented
Nov 12, 2025
since it depends on EVM-specific types and the alloy crate
tamaralipows
force-pushed
the
testing-sdk/tnl/ENG-5267-add-validators
branch
from
22fa6f7 to
8978571
Compare
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank you @tamaralipows ! 🙏🏼 I have some suggestions..
added 5 commits
November 12, 2025 19:00
- Validating one component at a time will be way too slow. We must batch similar to how we do in execution_simulator.rs. The actual processing of the batch results can happen one-component-at-a-time since this is not the slowest part. - For this, we need `batch_validate_components` and `execute_batched_calls` helper methods. We also still need to downcast in main.rs (looking for another solution)
Similar to how TychoStreamDecoder::register_decoder() associates protocol names with types implementing TryFromWithBlock, get_validator() provides a centralized place to map protocol names to types implementing Validator. While the decoder uses a registry pattern with closures for more flexibility, get_validator() uses a simpler match statement since validation downcasting is more straightforward (doesn't require runtime registration).
This can be logged earlier.
kayibal
reviewed
Nov 13, 2025
added 2 commits
November 13, 2025 21:57
The UniswapV2 reserves are only updated when swapping, so we should be checking the reserves, not the balances
for better readability
tamaralipows
force-pushed
the
testing-sdk/tnl/ENG-5267-add-validators
branch
from
469928a to
d95fd37
Compare
dianacarvalho1
approved these changes
Nov 17, 2025
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank you @tamaralipows 🙏🏼 This looks good to me! I have only tiny suggestions
| } | ||
| } | ||
| }; | ||
| components_to_process.push((id.clone(), component, state.clone_box())); |
Collaborator
There was a problem hiding this comment.
can we put all of this component selecting in one big method? I think it fits nicely together now!
| } else { | ||
| error!( | ||
| component_id = %component_id, | ||
| "State validation failed" |
Collaborator
There was a problem hiding this comment.
could we log here the delta message? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.