feat: Add exchange_with_decoder_context to ProtocolStreamBuilder #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaralipows
approved these changes
Nov 17, 2025
Contributor
tamaralipows
left a comment
tamaralipows
left a comment
There was a problem hiding this comment.
Thank you! Minor things. Also
By this statement here
tycho-test but this is really specific to the integration test
Do you mean it's specific to the cluster integration test? So it's not used in the SDK?
Collaborator
Author
ai sorry, I meant "This was moved to tycho-test before but it is actually really specific to the integration test and not used anywhere else." |
This is necessary for the full sdk test. We need a way to use the ProtocolStreamBuilder with DecoderContext Took 25 minutes Took 37 seconds Took 11 seconds
This was moved to tycho-test but this is really specific to the integration test. Bonus: Derive clone for RouterOverwritesData Took 43 seconds
Co-authored-by: Tamara <[email protected]>
Took 18 minutes
dianacarvalho1
force-pushed
the
test/dc/ENG-4968-support-full-test-sdk
branch
from
08f8c31 to
c2032ba
Compare
|
This PR is included in version 0.197.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: