Add makeNew parameter to copy() function in ObjectBuilder #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add makeNew parameter to copy() function in ObjectBuilder
marcj
reviewed
Oct 15, 2016
Incognito
suggested changes
Jul 13, 2020
Contributor
Incognito
left a comment
Incognito
left a comment
There was a problem hiding this comment.
This would also require tests that make use of this new feature.
The concept seems great on paper, it would help a lot with situations where you want idempotent mutation.
Something else to consider: Is there a way to do this without adding a new parameter to the method? Boolean params are usually red-flags for Single Responsibility Principle violations.
Co-authored-by: Brian Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.