add INT8 to isNumber method #2018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add INT8 to isNumber method |
add microtime for primary key
|
Someone needs to confirm, but Can you please rebase you PR and look at the changes in the review? Thanks! |
smhg
suggested changes
May 2, 2025
| @@ -12,6 +12,9 @@ public function preSave(?ConnectionInterface $con = null): bool | |||
| return parent::preSave($con); | |||
| } | |||
| <?php endif?> | |||
| if ($this->isNew() && !$this->getId()) { | |||
There was a problem hiding this comment.
These 3 lines seem to have been added to your commit by mistake. If so, can you please remove it?
| @@ -777,7 +777,7 @@ public function isString(string $type): bool | |||
| */ | |||
| public function isNumber(string $type): bool | |||
| { | |||
| $numbers = ['INTEGER', 'INT4', 'INT2', 'NUMBER', 'NUMERIC', 'SMALLINT', 'BIGINT', 'DECIMAL', 'REAL', 'DOUBLE PRECISION', 'SERIAL', 'BIGSERIAL']; | |||
| $numbers = ['INTEGER', 'INT4', 'INT2','INT8', 'NUMBER', 'NUMERIC', 'SMALLINT', 'BIGINT', 'DECIMAL', 'REAL', 'DOUBLE PRECISION', 'SERIAL', 'BIGSERIAL']; | |||
There was a problem hiding this comment.
Can you please add a space before 'INT8' (like the other values have)? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.