Skip to content

Fix/strict nullables #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eelkevdbos
Copy link
Contributor

@eelkevdbos eelkevdbos commented Apr 20, 2025

Closes #2038

@murraycollingwood
Copy link

Can we skip the php 7.4 tests and release this please?

PHP 7.4 was released on November 28, 2019. Its end-of-life (EOL) date, meaning no more bug or security fixes, was November 28, 2022.

I'm setting up a new machine and we're moving immediately to php 8.4

Alternatively, is there anything I can do to help this along? I've not contributed before, but there probably are some simple "type" errors that I could help with.

@eelkevdbos
Copy link
Contributor Author

Can we skip the php 7.4 tests and release this please?

I would have no problem with that.

Alternatively, is there anything I can do to help this along? I've not contributed before, but there probably are some simple "type" errors that I could help with.

I'm patching one file per commit for easy rollback / cherry picking, but I'm not really sure if there is a faster way without having conflicts because of overlapping work. I'll try to finish the nullable warnings this week.

@eelkevdbos eelkevdbos force-pushed the fix/strict-nullables branch from 191da4f to dd49db9 Compare April 21, 2025 06:18
@eelkevdbos eelkevdbos marked this pull request as ready for review April 21, 2025 14:01
@mringler
Copy link
Contributor

I think most of those are fixed in #2019.

Let me know when you are finished, I am happy to merge this into perpl (I don't think this repository is actively maintained anymore).

@smhg
Copy link
Contributor

smhg commented May 21, 2025

@eelkevdbos would you be able to rebase this PR please?
#2019 got merged and tests are fixed. So rebasing will give us a clear picture of what remains.
Thanks!

@eelkevdbos eelkevdbos force-pushed the fix/strict-nullables branch from dd49db9 to 8868928 Compare May 21, 2025 14:19
@eelkevdbos
Copy link
Contributor Author

@eelkevdbos would you be able to rebase this PR please?
#2019 got merged and tests are fixed. So rebasing will give us a clear picture of what remains.
Thanks!

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.4 Implicitly marking parameter as nullable is deprecated
4 participants