-
Notifications
You must be signed in to change notification settings - Fork 398
Fix/strict nullables #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix/strict nullables #2039
Conversation
Can we skip the php 7.4 tests and release this please?
I'm setting up a new machine and we're moving immediately to php 8.4 Alternatively, is there anything I can do to help this along? I've not contributed before, but there probably are some simple "type" errors that I could help with. |
I would have no problem with that.
I'm patching one file per commit for easy rollback / cherry picking, but I'm not really sure if there is a faster way without having conflicts because of overlapping work. I'll try to finish the nullable warnings this week. |
191da4f
to
dd49db9
Compare
I think most of those are fixed in #2019. Let me know when you are finished, I am happy to merge this into perpl (I don't think this repository is actively maintained anymore). |
@eelkevdbos would you be able to rebase this PR please? |
dd49db9
to
8868928
Compare
Done! |
Closes #2038