Skip to content

docs: PR workflow — branch naming convention and template-based PR creation#106

Closed
aaronbrezel wants to merge 8 commits into
mainfrom
develop
Closed

docs: PR workflow — branch naming convention and template-based PR creation#106
aaronbrezel wants to merge 8 commits into
mainfrom
develop

Conversation

@aaronbrezel

Copy link
Copy Markdown
Member

Summary

  • Add ### Branch Naming section to CLAUDE.md documenting the AI-{n}-description convention; instructs Claude to prompt for a Linear issue ID at branch creation and to warn (with confirmation gate) at PR creation if the branch name lacks an issue ID
  • Update ### Creating PRs to a three-step workflow: branch name check, PR body assembly from .github/PULL_REQUEST_TEMPLATE.md (Summary from diff, feature-specific QA steps + regression checklist, Notes), and curl-based creation with Python JSON escaping
  • Add design spec and implementation plan to docs/superpowers/ documenting the decisions (public repo → no Linear URLs in PR bodies; branch name alone triggers Linear integration)

Manual QA

Complete for PRs targeting main. Mark N/A with reason for PRs targeting develop.

  1. Review CLAUDE.md## GitHub### Branch Naming: confirm the AI-{n}-description format, examples, Linear auto-detection note, and enforcement instructions for branch creation and PR creation are clear and complete
  2. Review CLAUDE.md## GitHub### Creating PRs: confirm Steps 1–3 (branch check, body assembly, curl command) are unambiguous and actionable for a future Claude session
  3. Verify docs/superpowers/specs/2026-06-02-pr-workflow-design.md and docs/superpowers/plans/2026-06-02-pr-workflow.md are present and readable
  • Add-on menu appears after opening a Sheet
  • Sidebar opens without errors
  • Import Drive Links — imports files from a folder
  • Extract Text — extracts text from a Doc/PDF/image
  • Sample Rows — samples rows reproducibly with a seed
  • Run AI — batch inference completes and writes output column
  • Tested on a Sheet the tester does not own (shared access)

Notes

Documentation-only change — no source code or tests modified. All 489 tests pass.

aaronbrezel and others added 8 commits May 7, 2026 13:18
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs: update GitHub auth section for Docker Sandbox environment

Documents the proxy-based credential injection model accurately:
- Explains why gh CLI fails (proxy tunnel incompatibility in Go's net/http)
- Explains why git push works (libcurl handles the proxy tunnel correctly)
- Removes stale TLS workarounds (-k flag, TOKEN=$(gh auth token))
- Adds troubleshooting step for git push credential failures

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: clarify HTTPS-only git support in Docker Sandbox

SSH remotes require host-side SSH agent setup and network policy
changes; HTTPS works out of the box via proxy credential injection.
Adds remote URL switch command and link to Docker Sandbox SSH docs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: ignore Docker Sandbox dotfiles written to project root

The sandbox writes shell and tool config files (.bashrc, .zshrc,
.gitconfig, .mcp.json, etc.) to the project directory. Also fixes
.vscode/.idea patterns by removing trailing slashes which weren't
matching correctly in the sandbox git environment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant