Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A click below the last block returned early when the bottom textblock was an empty line, so the browser placed the caret there. When that line is a child of a folded bullet, it is hidden with
display: none:prosemirror-view1.43 places the caret itself withposAtCoordsandTextSelection.near. Those do not check visibility, so the caret goes into the hidden line. In Firefox, typed text goes there too. This fails "keeps the caret visible when the empty line is folded away" on 1.43.0-beta3.Changes:
getClientRects().length > 0).The extra layout read runs only on a press below the last block whose bottom line is empty, after the other early returns.
click-below.test.tsxpasses in Chromium, Firefox, and WebKit with bothprosemirror-view1.42.9 and 1.43.0-beta3.Written by Claude Opus 5.5.