tests for redis-client pkg #2287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the redis-client package, covering the core functionality for managing Redis connections and indexes.
Key Changes:
- Added unit tests for Redis index creation and deletion operations
- Added unit tests for Redis client connection and index setup utilities
- Implemented test coverage for hash-based index change detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/redis-client/src/tests/redisIndex.unit.test.ts | Tests for createRedisIndex and deleteRedisIndex functions including hash-based change detection and index lifecycle management |
| packages/redis-client/src/tests/redisClient.unit.test.ts | Tests for connectToRedis and setupRedisIndex functions including connection state management, error handling, and logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add comprehensive unit tests for connectToRedis function - Test connection state management, error handling, and logging - Add unit tests for setupRedisIndex function - All tests use proper mocking of redis client and logger
- Add test:unit script for running unit tests - Update test script to run both unit and integration tests - Use TEST_TYPE environment variable for test filtering
…nt-package' into fix/test-redis-client-package
- Add @testcontainers/redis and testcontainers dependencies - Update testRedisConnection to use testcontainers Redis container - Add comprehensive integration tests for redisClient - Enhance redisIndex integration tests with additional coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.