fix(feedback): hide side panel drop shadow when panel is closed#122
Merged
Conversation
The injected feedback side panel is hidden by translating it offscreen (translateX(±100%)), but its box-shadow bled back into the viewport, leaving a persistent shadow edge even when the panel was closed. Move the box-shadow onto the .veld-feedback-panel-open state only and add box-shadow to the transition so it fades in/out with the panel. The base state keeps a transparent zero-spread shadow as an animatable baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The injected feedback side panel is hidden by translating it offscreen (
transform: translateX(±100%)), but itsbox-shadowbled back into the viewport — leaving a persistent shadow edge along the screen border even when the panel was closed.Fix
box-shadowonto the.veld-feedback-panel-openstate only (both right and left variants), so it appears solely when the panel is visible.box-shadowto the panel'stransitionso it fades in/out together with the slide.box-shadow: 0 0 0 rgba(0,0,0,0)as the base state — required as an animatable baseline (nonecannot transition to a shadow value).Scope
Internal CSS-only bugfix to the feedback overlay. No new config fields, CLI flags, or user-visible surface area — documentation checklist does not apply.
Test
npm run buildincrates/veld-daemon/frontendsucceeds (CSS bundles into the overlay JS via esbuild, embedded at cargo build).