refactor: reimplement IdentifiersEntry schema instead of identifiers JSON field #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoward-lm
added
enhancement
jhoward-lm
requested review from
fkautz,
eddiezane,
puerco,
cpanato and
veramine
jhoward-lm
force-pushed
the
identifiers-entries
branch
2 times, most recently
from
bef1c96 to
5fd2e23
Compare
…JSON field Signed-off-by: Jonathan Howard <[email protected]>
Signed-off-by: Jonathan Howard <[email protected]>
jhoward-lm
force-pushed
the
identifiers-entries
branch
from
5fd2e23 to
ad1a18b
Compare
puerco
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the
IdentifiersEntryschema as it was implemented previously instead of storing themap[int32]stringtype as raw JSON data.Diff against previous branch in the PR series: link
Depends on #55
Note
Only the following files are manually modified; the rest are auto-generated
backends/ent/*.gointernal/backends/ent/schema/*.go/cc @ashearin @lmphil