Add test case where parse, tokenizer fails with empty option #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a fix just yet, trying to understand the code first, but wanted to open this PR for any guidance on the correct place to fix this test case. My application is interacting with a service that has an empty option therefore the parser fails. I figured his library should fail gracefully if the user has not set any option.
It seems the best place to fix this would be in the parse.js file in the
parseOption > parseOptionValue
on line 561 and 564.