Ensure descriptor conversion can handle default values #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes protobufjs#1196 If the descriptor has been serialized/deserialized by something that set the default values, then an error occurs during reading the descriptor. This fixes it.
|
I wasn't sure what to do about tests here - I did add something to the tests for the descriptor, but that isn't run by the main build as far as I can see, and it doesn't even use a test framework. I'd be happy to make it use tape, just let me know what should be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196
If the descriptor has been serialized/deserialized by something that set the default values, then an error occurs during reading the descriptor. This fixes it.