Skip to content

Fixed codegen if exported type name ends with ".Object" #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

initial-wu
Copy link

Message named Object should be allowed when a package name is specified.

syntax = "proto3";
package foo;
message Object {
    int32 bar = 1;
}
'Object.'.match(/((?<!\.)\bObject\b(?!\.))/g) // null
'.Object'.match(/((?<!\.)\bObject\b(?!\.))/g) // null
'Object'.match(/((?<!\.)\bObject\b(?!\.))/g) // ["Object"]

@initial-wu initial-wu changed the title Fixed codegen if type name ends with ".Object" Fixed codegen if exported type name ends with ".Object" Mar 7, 2021
@alexander-fenster
Copy link
Contributor

@initial-wu Can you please include a regression test that fails without your change and passes with your change, and also fix the formatting so that lint passes? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants