Skip to content

feat(csharp/Reflection): change MessageParser.CreateTemplate to be public #19776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahmednfwela wants to merge 2 commits into from
Closed

feat(csharp/Reflection): change MessageParser.CreateTemplate to be public #19776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb60c7
feat: change MessageParser.CreateTemplate to be public
ahmednfwela Dec 23, 2024
fdabaaa
Merge branch 'main' of github.com:protocolbuffers/protobuf into feat/…
ahmednfwela Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions csharp/src/Google.Protobuf.Test/Reflection/DescriptorsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,23 @@ namespace Google.Protobuf.Reflection
/// </summary>
public class DescriptorsTest
{
[Test]
public void CreateTemplate_Typed()
{
var wktStructParser = WellKnownTypes.Struct.Parser;
var template = wktStructParser.CreateTemplate();
Assert.AreEqual(template, new WellKnownTypes.Struct());
}

[Test]
public void CreateTemplate_Untyped()
{
IMessage original = new WellKnownTypes.Struct();
var parser = original.Descriptor.Parser;
var template = parser.CreateTemplate();
Assert.AreEqual(template, new WellKnownTypes.Struct());
}

[Test]
public void FileDescriptor_GeneratedCode()
{
Expand Down
4 changes: 2 additions & 2 deletions csharp/src/Google.Protobuf/MessageParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ internal MessageParser(Func<IMessage> factory, bool discardUnknownFields, Extens
/// Creates a template instance ready for population.
/// </summary>
/// <returns>An empty message.</returns>
internal IMessage CreateTemplate()
public IMessage CreateTemplate()
{
return factory();
}
Expand Down Expand Up @@ -246,7 +246,7 @@ internal MessageParser(Func<T> factory, bool discardUnknownFields, ExtensionRegi
/// Creates a template instance ready for population.
/// </summary>
/// <returns>An empty message.</returns>
internal new T CreateTemplate()
public new T CreateTemplate()
{
return factory();
}
Expand Down
Loading