Fix cc_library protoc_lib defines main() #12887 #20016
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
added
🅰️ safe for tests
mkruskal-google
approved these changes
Jan 23, 2025
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
wait for user action
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
| @@ -234,27 +233,16 @@ alias( | |||
| visibility = ["//visibility:public"], | |||
| ) | |||
|
|
|||
| cc_binary( | |||
There was a problem hiding this comment.
Looks like there's still a bunch of test failures related to the alias/cc_binary switch. There are a pretty large number of places where we assume protoc and protoc_static get dumped directly into bazel-bin, and this change moves the binaries somewhere else.
I agree with the direction, and it would be nice to keep as much as possible in //src/google/protobuf/compiler, but I think the cc_binary targets need to live here for now (to avoid a major refactor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #12887