Skip to content

Load py_runtime_pair from rules_python for Bazel 8 #20335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justinwon777
Copy link

@justinwon777 justinwon777 commented Feb 13, 2025

Bazel 8 requires loading py_runtime_pair from rules_python since it's deprecated in bazel_tools and causes failure. See https://github.com/bazelbuild/bazel/blob/8.0.0/tools/python/toolchain.bzl

@justinwon777 justinwon777 requested a review from a team as a code owner February 13, 2025 02:06
@justinwon777 justinwon777 requested review from ericsalo and removed request for a team February 13, 2025 02:06
@shaod2 shaod2 added python bazel 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Feb 13, 2025
@tonyliaoss tonyliaoss self-assigned this Feb 18, 2025
@tonyliaoss tonyliaoss added cla: yes 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Feb 19, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 19, 2025
@justinwon777
Copy link
Author

Hi @tonyliaoss. Do I need to do anything with the failing checks or is it fine?

copybara-service bot pushed a commit that referenced this pull request May 12, 2025
As suggested by @justinwon777 in #20335

PiperOrigin-RevId: 757604699
copybara-service bot pushed a commit that referenced this pull request May 12, 2025
As suggested by @justinwon777 in #20335

PiperOrigin-RevId: 757604699
copybara-service bot pushed a commit that referenced this pull request May 12, 2025
As suggested by @justinwon777 in #20335

PiperOrigin-RevId: 757933716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants