[C#] Adding Clear mechanism to IMessage #21472
Open
+6,071
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed myself as a reviewer as I don't have time to consider this thoroughly, but if I were reviewing it I would reject it in its current state as adding a method to an interface is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In C# game development or real-time bidding, object pooling is a common way to optimize. However, the C# runtime of Protobuf does not support Clear message. See issue: #18782.
This pull request add Clear method to IMessage.cs, makes Protobuf C# message can be reused.
What's added or changed
If this pull request has any breaking changes or improvement, please let me know. And I will try my best to improve it.
Thanks for your time.