Generate .pyi files in py_proto_library (#10366) #21567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1; with |
anandolee
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
@anandolee Thanks for adding the tag! It looks like my PR passes CI, so I look forward to your review. |
mkruskal-google
added
python
bazel
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
dws
added a commit
to dws/protobuf
that referenced
this pull request
Jun 3, 2025
We here update the minimum required version of `rules_python` from 1.0.0 to 1.1.0 in order to enable using the new `direct_pyi_files` and `transitive_pyi_files` members of `PyInfo` in protocolbuffers#21567. Closes protocolbuffers#22078.
dws
force-pushed
the
py_proto_library-pyi
branch
3 times, most recently
from
3c5da60 to
a4bbe43
Compare
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Jun 9, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
We here update the minimum required version of `rules_python` from 1.0.0 to 1.1.0 in order to enable using the new `direct_pyi_files` and `transitive_pyi_files` members of `PyInfo` in #21567. Closes #22078. Closes #22079 COPYBARA_INTEGRATE_REVIEW=#22079 from dws:rules_python-1.1.0 7d0dc78 PiperOrigin-RevId: 769258504
|
@mkruskal-google Now that the rules_python bump has landed, please try another round of CI here. |
|
@mkruskal-google ping? |
1 similar comment
|
@mkruskal-google ping? |
|
@anandolee perhaps you could enable a new round of CI testing? I think that's all that should be needed to land this now that it is approved. |
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Jul 1, 2025
We here adjust py_proto_library to produce `.pyi` files along with the `.py` files it already generates. This achieves the same effect as the gRPC py_proto_library. Closes protocolbuffers#10366.
Per reviewer feedback, we here propagate the paths to the `.pyi` files via the `direct_pyi_files` and `transitive_pyi_files` members of `PyInfo` which are available starting in `rules_python` 1.1.0. Since this means that the files are not automatically in the runfiles of the `py_proto_library`, tooling to run mypy will need to be adjusted to add what is needed from these provider fields to the runfiles if that is what is wanted.
mkruskal-google
added
the
🅰️ safe for tests
mkruskal-google
approved these changes
Jul 1, 2025
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We here adjust py_proto_library to produce
.pyifiles along with the.pyfiles it already generates. This achieves the same effect as the gRPC py_proto_library.Per reviewer feedback, we here propagate the paths to the
.pyifiles via the
direct_pyi_filesandtransitive_pyi_filesmembersof
PyInfowhich are available starting inrules_python1.1.0.Since this means that the files are not automatically in the runfiles
of the
py_proto_library, tooling to run mypy will need to beadjusted to add what is needed from these provider fields to the
runfiles if that is what is wanted.
Closes #10366.